trigger view-cart only when the mini-cart is opened (Hyva) #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It's not the most elegant solution, naming can be improved here and there but it seems to do the job |
Contributor
Author
|
One more thing. This also impacts Luma-based themes. The change in |
Collaborator
|
Sorry for closing this - as mentioned elsewhere, I found the PR doing 2 things at once, and had disagreements with 1 thing (the minicart fix). Still, with your thought and input, the issue got resolved. The other fix - regarding the category display mode - is spot on. I copied the code and your name will be added to the CHANGELOG: 2736d76 Many thanks for spotting that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.