Skip to content

Fix view cart event again #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jissereitsma merged 2 commits into from
Nov 27, 2025
Merged

Fix view cart event again #293

jissereitsma merged 2 commits into from
Nov 27, 2025

Conversation

@samicoman
Copy link
Contributor

@samicoman samicoman commented Nov 25, 2025

  • makes sure the event fires as expected on the cart page; With the recent refactor, if the module is configured to only fire when mini-cart is viewed, no event is firing at page-load on the cart page, which is not ok, in my opinion.

@jissereitsma jissereitsma merged commit 4b7a428 into yireo:master Nov 27, 2025
1 of 2 checks passed
@jissereitsma
Copy link
Collaborator

jissereitsma commented Nov 27, 2025

Thanks for spotting this.

@hostep hostep mentioned this pull request Dec 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samicoman @jissereitsma