refactor: use selection bookmarks to support all possible selection types #182
+70
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nperez0111
commented
Apr 15, 2025
Comment on lines
+250
to
+254
| export const relativePositionStore = (pmbinding, pos) => { | ||
| const relPos = absolutePositionToRelativePosition(pos, pmbinding.type, pmbinding.mapping) | ||
|
|
||
| return (binding = pmbinding) => { | ||
| return relativePositionToAbsolutePosition(binding.doc, binding.type, relPos, binding.mapping) |
There was a problem hiding this comment.
This doesn't necessarily have to be exported, I thought it was just a useful abstraction to have. Happy to inline it if we don't want it
|
This would be great – nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely overhauls selection restoration to be based on Prosemirror Bookmarks which are used to store & restore selections independent of the current document.
This is useful for y-prosemirror, since it means that we do not have to implement each selection type, yet all of them will work.
These also fallback to a TextSelection.between if a bookmark, if invalid or unimplemented, which is a good default.
Resolves: