Skip to content

support marks on element nodes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

support marks on element nodes #63

wants to merge 6 commits into from

Conversation

BrianHung
Copy link
Contributor

@BrianHung BrianHung commented Aug 16, 2021 •
edited
Loading

#47

@BrianHung
Copy link
Contributor Author

BrianHung commented Aug 16, 2021 •
edited
Loading

An alternative serialization method might be to just use setAttribute('marks', node.marks) to distinguish between attrs and marks.

This would also allow marks to retain its expected properties of being an array (which help with #52), and we wouldn't also have to rely on schema to tell if something is a mark or attrs.

@BrianHung BrianHung mentioned this pull request Aug 17, 2021
Open
@alexharri alexharri mentioned this pull request May 31, 2022
Open
2 tasks
This was referenced Dec 23, 2022
Closed
Merged
@Bajena
Copy link

Bajena commented Jun 28, 2024

Hi @dmonad would there be any chance you could take a look at this PR? It'd help us a lot to solve some inconsistencies. Thank you 🙇

@Pruxis Pruxis mentioned this pull request Jul 2, 2024
Open
west1636 added a commit to west1636/y-prosemirror that referenced this pull request Oct 1, 2024
@west1636
apply yjs#63
9b689b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrianHung @Bajena