Adds support for passing Authentication Credentials & Query Params via CALLBACK_URL - #131
Open
Sonictherocketman wants to merge 1 commit into
Open
Adds support for passing Authentication Credentials & Query Params via CALLBACK_URL#131Sonictherocketman wants to merge 1 commit into
Sonictherocketman wants to merge 1 commit into
Conversation
…a CALLBACK_URL This change allows for a server to contain both query params and optional HTTP Basic Auth credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for a server to contain both query params and optional HTTP Basic Auth credentials.
Currently no mechanism exists for a
CALLBACK_URLto contain an authentication token either in the query string or as basic auth. A lack of such mechanism limits the utility of the CALLBACK_URL over unsecured networks or multi-node setups.