Skip to content

Support PCZT clear signing - #32

Merged
Fingolfin69 merged 9 commits into
bn-feat-pcztfrom
pczt-clear-signing
Jun 23, 2026
Merged

Fingolfin69 merged 9 commits into
bn-feat-pcztfrom
pczt-clear-signing

Conversation

@Fingolfin69

@Fingolfin69 Fingolfin69 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Add clear signing support for Orchard transactions (also supports cross-pool self-transfers)
  • Harden Orchard PCZT clear signing by requiring rcv and spend note fields,
  • Verifying cv_net and spend nullifiers, and rejecting undecryptable
  • Dummy-output validation is implemented.
  • Add memo support

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@Fingolfin69 Fingolfin69 self-assigned this Jun 22, 2026
@Fingolfin69
Fingolfin69 requested a review from may01 June 22, 2026 01:10
@Fingolfin69 Fingolfin69 changed the title Supprot PCZT clear signing Support PCZT clear signing Jun 22, 2026
Comment thread ledger_zcash_crypto/src/poseidon.rs Outdated
@Fingolfin69

Copy link
Copy Markdown
Collaborator Author

Added memos support. Fixed some AI review comments.

@Fingolfin69
Fingolfin69 requested a review from may01 June 22, 2026 14:58
@socket-security

socket-security Bot commented Jun 22, 2026

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@Fingolfin69

Fingolfin69 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

It seems pip package cache is broken in this repository https://github.com/yldio/app-rust-zcash/actions/runs/27965542780/job/82758881173?pr=32.

The same branch with the same commits is passing CI successfully in another repository: Fingolfin69#4.

@may01, if possible, could you please remove CI caches (Actions -> Caches)?

@Fingolfin69 Fingolfin69 mentioned this pull request Jun 22, 2026
7 tasks
Base automatically changed from bn-pczt-orchard-actions to bn-feat-pczt June 22, 2026 20:44

@cted-ledger cted-ledger left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fingolfin69
Fingolfin69 merged commit 6cbf11b into bn-feat-pczt Jun 23, 2026
371 of 377 checks passed
@Fingolfin69
Fingolfin69 deleted the pczt-clear-signing branch June 23, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants