Extend private address flow with public address - #34
Closed
Fingolfin69 wants to merge 15 commits into
Closed
Conversation
Fingolfin69
changed the title
Fingolfin69
changed the title
PCZT support
Fingolfin69
force-pushed
the
bn-extend-private-address-flow
branch
from
June 24, 2026 10:13
80f69f9 to
ba7a2cc
Compare
cted-ledger
reviewed
Jun 29, 2026
cted-ledger
left a comment
cted-ledger
left a comment
There was a problem hiding this comment.
Matches the NAPPS-1355 Figma (3-page verify flow: private Orchard UA, then public T-address, then confirm) and the DOD (Ragger tests + snapshots across devices). No blockers — the Orchard-only UA plus a separately shown public address is the intended design. Two small nits inline.
Fingolfin69
changed the base branch from
bn-feat-pczt
to
bn-feat-extend-private-address-flow
June 30, 2026 01:48
Fingolfin69
force-pushed
the
bn-extend-private-address-flow
branch
from
June 30, 2026 04:04
0324c5f to
5e9ed71
Compare
cted-ledger
approved these changes
Jun 30, 2026
Migrate ruff
Security fixes
Y333/migrate ruff
Apply ruff config
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
may01
force-pushed
the
bn-extend-private-address-flow
branch
from
July 7, 2026 10:14
3646a56 to
ca4b79b
Compare
Add transparent derivation path parameter to INS_GET_SHIELD_ADDR and INS_GET_VK commands, harden address mismatch checks, and update snapshots and tests accordingly.
may01
force-pushed
the
bn-extend-private-address-flow
branch
from
July 7, 2026 17:24
fb5caab to
35bd8ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
develop