Skip to content

Conversation

@samsonasik
Copy link
Contributor

@samsonasik samsonasik commented Jan 10, 2025

version in composer.json is not recommended by composer validate command

➜  ci4-pages git:(main) composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- The version field is present, it is recommended to leave it out if the package is published on Packagist.

Also add gitHub actions step to validate it.

as composer.lock is not committed, on local, composer.lock can be regenerated:

composer update

@samsonasik
Copy link
Contributor Author

@yllumi ready to merge 👍

@yllumi yllumi merged commit fd32c59 into yllumi:main Jan 20, 2025
2 checks passed
@samsonasik samsonasik deleted the chore-remove-version-in-composer-json branch January 20, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants