test: make smoke hermetic to GALLEY_HOST in the caller's shell - #65
Merged
Conversation
Devbox shells export GALLEY_HOST=0.0.0.0 so real desks bind beyond loopback, but smoke's waitForDeskUrl asserts the loopback URL — an inherited GALLEY_HOST made every local `pnpm smoke`/`pnpm release` time out. Strip it (and GALLEY_ALLOWED_HOSTS) from the env passed to spawned desks and CLI calls. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/smoke.mjspasses the caller's full environment to the spawned desk, and itswaitForDeskUrlmatcher asserts the loopback URL (http://127.0.0.1:<port>). In a shell that exportsGALLEY_HOST(the devbox/tailnet pattern the--hostfeature is built for), the desk binds beyond loopback and prints a non-loopback URL, so every localpnpm smoke/pnpm releasetimes out — while CI, with no such variable, stays green.Fix: build one sanitized env (
GALLEY_HOSTandGALLEY_ALLOWED_HOSTSdeleted,GALLEY_NO_UPDATE_CHECK=1kept) and use it for both the desk spawn and the agent-subcommandcli()calls.Verified by running
node scripts/smoke.mjsin a shell withGALLEY_HOST=0.0.0.0exported: previously timed out, nowSMOKE PASS.🤖 Generated with Claude Code