Skip to content

Stylistic fixes based on Codacy suggestions #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jun 26, 2023
Merged

Stylistic fixes based on Codacy suggestions #667

merged 25 commits into from
Jun 26, 2023

Conversation

ymcui
Copy link
Owner

@ymcui ymcui commented Jun 25, 2023

Description

miscellaneous doc/script fixes based on Codacy suggestions.

Related Issue

None.

Explanation of Changes

copilot:walkthrough

@ymcui ymcui marked this pull request as draft June 25, 2023 13:00
airaria and others added 23 commits June 25, 2023 21:16
@airaria
Update prompt_template
0c95b61
@ymcui
stylistic update based on Codacy
ce78c23
@ymcui
Merge branch 'doc_fix' of https://github.com/ymcui/Chinese-LLaMA-Alpaca…
3dd35da 
… into doc_fix
@ymcui
stylistic update based on Codacy
7e92605
@ymcui
stylistic update based on Codacy
f531c6f
@ymcui
stylistic update based on Codacy
d8bd567
@iMountTai
Update openai_api_server.py
b88c2ed 
remove unused import
@iMountTai
stylistic update based on Codacy
2935363
@iMountTai
Update run_clm_sft_with_peft.py by Codacy
f493d9a
@iMountTai
Stylistic fixes based on Codacy suggestions
d89f53c
@iMountTai
Stylistic fixes based on Codacy suggestions
c74c72f
@iMountTai
Update build_dataset.py by Codacy
e926f87
@airaria
Update openai_api_server.py
66fe1b6
@airaria
Update openai_api_server.py
5817b40
@airaria
Stylistic update run_clm_pt_with_peft.py based on Codacy
a9f9ed2
@airaria
Update run_clm_sft_with_peft.py
4d02338 
Stylistic update run_clm_sft_with_peft.py based on Codacy
@ymcui
Trailing whitespace
53b5607
@ymcui
Trailing whitespace
c04757d
@ymcui
Trailing whitespace
c985552
@ymcui
Trailing whitespace
8f5f621
@airaria
remove unused variable in run_clm_sft_with_peft.py
6406fe6
@airaria
remove unused function smart_tokenizer_and_embedding_resize
e556718
@airaria
remove unused Dict imported from typing
a96009b
@ymcui ymcui marked this pull request as ready for review June 26, 2023 01:08
@ymcui
Copy link
Owner Author

ymcui commented Jun 26, 2023

Please review these changes to avoid any unexpected behaviors caused by these stylistic changes. @airaria @iMountTai

@ymcui ymcui requested a review from iMountTai June 26, 2023 01:18
@ymcui ymcui requested a review from airaria June 26, 2023 01:18
airaria
airaria reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@airaria airaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed each change, and it is highly unlikely that they will result in any unforeseen or unexpected behaviors.

iMountTai
iMountTai approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@iMountTai iMountTai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pt code and sft code work properly. Other file changes have no impact.

@ymcui ymcui merged commit 8563833 into main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airaria airaria airaria approved these changes

@iMountTai iMountTai iMountTai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymcui @airaria @iMountTai