Settings-driven inventory labels #1353
Open
+90
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
added
community
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
| self._clear_items() | ||
| # fetch the label settings | ||
|
|
||
| settings = get_project_settings( |
Member
There was a problem hiding this comment.
This whole shebang of getting the template should be implemented in controller not in UI.
Here should be just
group_name_template = self._controller.get_label_template()
Member
There was a problem hiding this comment.
Or maybe even better, the container items should be returned with the label prepared...
UI should only show what controller (and models) prepare for data. In ideal case scenario should not make any calls using ayon_api or call host method.
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
iLLiCiTiT
reviewed
Jul 1, 2025
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Allows the inventory item labels to be driven by settings.
Part of RVX's summer of pull requests