Skip to content

Active button for Extract Image and Extract Layers - #132

Merged
moonyuet merged 4 commits into
developfrom
enhancement/YN-1051--Active-button-for-Extract-Image-and-Extract-Layer
Sep 4, 2026
Merged

Active button for Extract Image and Extract Layers#132
moonyuet merged 4 commits into
developfrom
enhancement/YN-1051--Active-button-for-Extract-Image-and-Extract-Layer

Conversation

@moonyuet

@moonyuet moonyuet commented Sep 2, 2026

Copy link
Copy Markdown
Member

Changelog Description

This PR is to add active button for Extract Image and Extract Layers.
Resolve #131

Additional review information

n/a

Testing notes:

  1. Build and install PS addon with this branch
  2. you would find active button in ayon+settings://photoshop/publish/ExtractImage and ayon+settings://photoshop/publish/ExtractLayers

@moonyuet
moonyuet requested a review from LiborBatek September 2, 2026 11:54
@moonyuet moonyuet self-assigned this Sep 2, 2026
@moonyuet moonyuet added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Sep 2, 2026
@BigRoy
BigRoy requested a lite review from Copilot September 2, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small and self-contained, with only minor consistency nits noted around field ordering in the settings models.

Pull request overview

Adds an active toggle to the Photoshop addon publish plugin settings for Extract Image and Extract Layers, matching the request in issue #131 to control default plugin activation state via Settings.

Changes:

  • Added active: bool to ExtractImagePlugin and ExtractLayersPlugin settings models.
  • Added default active values for ExtractImage and ExtractLayers in DEFAULT_PUBLISH_SETTINGS.
File summaries
File Description
server/settings/publish_plugins.py Adds active fields + defaults for Extract Image/Layers publish plugin settings so the Settings UI can expose an “Active” toggle.
Review details

Suppressed comments (1)

server/settings/publish_plugins.py:152

  • For consistency with other publish plugin setting models in this file (e.g. ValidateSmartObjectLinksPlugin and ValidateDocumentSettingsPlugin), consider keeping the field order as enabled, optional, then active so the Settings UI presents these toggles consistently.
    enabled: bool = SettingsField(False, title="Enabled")
    active: bool = SettingsField(True, title="Active")
    optional: bool = SettingsField(False, title="Optional")
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread server/settings/publish_plugins.py
moonyuet and others added 2 commits September 3, 2026 10:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@moonyuet
moonyuet requested a review from BigRoy September 3, 2026 04:26

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending test by @LiborBatek

@LiborBatek LiborBatek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my combo of settings been correctly propagated and shown in the Publisher UI.

Image Image

@moonyuet
moonyuet merged commit 6269d89 into develop Sep 4, 2026
1 check passed
@moonyuet
moonyuet deleted the enhancement/YN-1051--Active-button-for-Extract-Image-and-Extract-Layer branch September 4, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YN-1051: Active button for Extract Image and Extract Layer

5 participants