Chore: Plugins code refactor - #68
Merged
Merged
Conversation
iLLiCiTiT
added
type: enhancement
iLLiCiTiT
marked this pull request as draft
February 12, 2026 16:14
kalisp
approved these changes
Feb 16, 2026
kalisp
left a comment
kalisp
left a comment
Member
There was a problem hiding this comment.
Fixed one condition, but otherwise it seems to be working even in automatic tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Code refactor of publish plugins and orders unification.
Additional review information
This is an attempt to refactor plugins code and orders. Not all of the changes has to be merged, it is something I did start to do when prepared the addon for prodct base types. I didn't test any of the changes so it might not be correct.
With merge of ynput/ayon-core#1701 more changes can be made.
Change logic of few addons to skip logic based on settings earlier to avoid unnecessary checks if the plguin should not be running at all.
Split collect review plugin into 2 -> collect review only adds
"review"family to instance -> which can be also used in automated target and the same logic can be removed from collect auto review. And added new plugin collect review data which adds the context data to instances.Settings are access explicitly without
.get("...", {})but `["..."].Collect auto review instance does not add
"review"family to instances with"mark_for_review"as that should happen in Collect review.During the changes I did find inconsistencies of orders in ayon-core addon (also made a PR in ayon-core).
Testing notes:
First of all look at code changes and check them.