Add settings for default workfile extensions

[moonyuet]

Changelog Description

This PR is to add setting for default workfile extensions in ayon servers. User can choose and prioritize which extension they would like to save with workfile tool.

Additional review information

Resolve #90
Marked it as draft due to the ongoing discussion on the issue.

Testing notes:

1. Choose your preferred setting in ayon+settings://photoshop/default_workfile_extension
2. Launch PS
3. Click workfile
4. Save as -> the workfile extension should be .psb

[iLLiCiTiT]

Please read #90 (comment) and #90 (comment)

[iLLiCiTiT]

Code looks ok. @LiborBatek could you test?

[LiborBatek]

In essence it works for saving Workfile and psb...

There is a one caveat tho..when using Create First Workfile as it uses the preconfig template file and its extension (e.g. psd instead)...Im not saying its a bug, but it would be nice to also use psb file format when set as default file extension instead... not sure if we are just picking up the template file and its extension or calling separate save function for creating the very first workfile (which would be best approach, so it might conform to the extension config) ...

[BigRoy]

There is a one caveat tho..when using Create First Workfile as it uses the preconfig template file and its extension (e.g. psd instead)...Im not saying its a bug, but it would be nice to also use psb file format when set as default file extension instead... not sure if we are just picking up the template file and its extension or calling separate save function for creating the very first workfile (which would be best approach, so it might conform to the extension config) ...

Does it work if you make the template file itself .psb - if so, I think it's fine as is. If not, we may want to think about how to solve that then.

[LiborBatek]

Unfortunatelly it does not respect the template file so when using Psb extension for template file its re-saved to psd...seems like hardcoded saving call...

So we def. need to resolve it atm...

and when used to build first workfile:

[moonyuet]

@BigRoy @iLLiCiTiT not sure if it is safe to use the code below for workfile

    def save_workfile(self, filepath=None):
        filename, ext = os.path.splitext(filepath)
        if ext != self.workfile_extensions[0]:
            ext = self.workfile_extensions[0]
            filepath = f'{filename}{ext}'
        lib.stub().saveAs(filepath, ext.lstrip("."), False)

[iLLiCiTiT]

not sure if it is safe to use the code below for workfile

No. You should not change the extension.

and when used to build first workfile:

How did you trigger that?

[iLLiCiTiT]

Ok, the issue is related to templates hook in ayon-core fixed with this. It might be tricky to make this work without the change in ayon-core.

[BigRoy]

@LiborBatek can you try again with ynput/ayon-core#1889

[LiborBatek]

I have tested it with the ayon-core 1.9.7 and it works. It basically keeps the template file extension as is (whether its PSD or PSB) and once having some preference for saving workfiles in the settings it uses such extension...for following workfiles (e.g. very first from template as PSB while the newer workfiles then using settings prefs e.g. PSD)

LGTM

Note: I guess it might be to complicated to change the template extension to that preffered one (using the settings definition for file format instead - as now it simply keeps the original file extension which is okeyish imho)