Fix macOS Photoshop architecture selection - #95
Conversation
|
Code looks ok, no idea if it is doing what is supposed to be doing. |
|
Thanks for checking. I tested the macOS architecture selection behavior against these cases:
The change is intentionally conservative: if detection is uncertain, it keeps the existing behavior instead of forcing an architecture. If there is a specific environment you are worried about, I can add a targeted test case for it. |
|
(My comment was meant as a punt to @jakubjezek001 as he has Mac to actually test this;) I tested it on windows, if it doesn't break anything. It didn't. ) |
kalisp
left a comment
There was a problem hiding this comment.
Still works on Windows, must be tested on Mac.
|
So the Photoshop is launching as expected. I am on arm64 and not able to test the CEP builded plugin. I was actually testing recently this PR #88 and Photoshop was also launching for me. Questions:
|
Thanks for testing this on Apple Silicon. AYON Photoshop currently uses a CEP/ZXP extension, not UXP. This PR is architecture-based rather than plugin-type-based:
So this change does not launch UXP under Rosetta. For CEP, the x86_64-only Photoshop path is the one expected to use Rosetta. A CEP build test on Apple Silicon would be useful for final end-to-end confirmation. |
I don't think CEP is available on native Apple Silicon, or do you use it somehow in production? Ie. you ran PS natively on |
I do not have an Apple Silicon Mac to run the final verification, but the following checks should confirm the intended behavior:
The PR does not claim to make CEP natively arm64-compatible. It only avoids forcing universal Photoshop through Rosetta and preserves the x86_64/Rosetta path when required. |
|
I am not sure I follow, your PR is now running PS on My question was if you are using this in production, but this seems that this PR wasn't tested on mentioned environments. If I misunderstood, I apologize. If it is stripping CEP integration, it is not useful at this moment, at least until move to UXP is finalized and tested. |
Thanks for the clarification. This is helpful. You are right that the PR has not been validated on the environments you described, and I do not have an Apple Silicon Mac to perform that end-to-end test myself. The intended scope of this change is only architecture selection: preserve the x86_64/Rosetta path required by CEP, while avoiding an unnecessary Rosetta launch for universal Photoshop where appropriate. It does not claim that CEP works natively on arm64. If the current behavior breaks CEP integration on native arm64, then the PR should not be merged as-is. I am happy for the maintainers to close it until the UXP migration is finalized and tested. I hope the architecture-selection notes and fallback behavior are still useful for that future work. |
Fix macOS Photoshop architecture selection
Changelog Description
Launch Photoshop with a compatible architecture on macOS instead of always
forcing
x86_64.Additional review information
The current launcher prefixes every macOS invocation with
arch -x86_64. This prevents a universal Photoshop binary from launchingnatively as
arm64.The updated launcher reads the architectures supported by Photoshop and the
running Python executable with
lipo -archs:macOS selects the native architecture.
with the architecture supported by Photoshop. This preserves Rosetta
support for an x86-only Photoshop installation.
command instead of guessing an architecture.
Resolves #91
Testing notes
Run:
Covered cases:
Hardware verification on an Apple Silicon Mac is still recommended before
merge.