Skip to content

516 support #22996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

516 support #22996

wants to merge 38 commits into from

Conversation

JohnFulpWillard
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard commented Mar 16, 2025

Document the changes in your pull request

Used TG and Monke heavily as reference for this, TG for most TG code, Monkestation for TGUI cause they still use Inferno while TG uses React.

Ports all of https://github.com/tgstation/tgstation/milestone/98
Ports tgstation/tgstation#66971 in hopes that it'll help with tgui sometimes not loading properly
Ports tgstation/tgstation#66309

Re-adds #21028 - Fixes languages not translating properly. This fixes fonts not looking well in-game.

This does the following & more:

Makes all hrefs include byond://, which is necessary for 516
Replaces all uses of caller, it's now a very long name because I didn't go through each one to make them fit the procs they are in.
Fixes stat panel, cause it stopped working in 516
Fixes lighting looking very weird for users on 516

Let me know if you find any other bugs

Testing

image
image
image
image
image

Changelog

🆑
experimental: The game can now be compiled and played on 516.
/:cl:

@JohnFulpWillard JohnFulpWillard requested review from TheGamerdk and a team as code owners March 16, 2025 04:28
@github-actions github-actions bot added the Github changes to the .github folder label Mar 16, 2025
@ToasterBiome
Copy link
Contributor

ToasterBiome commented Mar 16, 2025

image
Missing icons

image
The plus sign here is invisible on both themes

image
more missing icons

image
i think these are supposed to have a backing color that isnt completely transparent

image
shows a song currently playing but nothing is playing

image
volume slider lookin suspicious asf

image
scroll bar wrong color for light skin

image
this menu is also fucked

I realize now that I think the assets just arent loading properly

Reconnect button also seems to not do anything (even less so than before)

@JohnFulpWillard
Copy link
Contributor Author

In order:
image
image
image
image
image

I can't replicate the problems you're having, except the character prefs menu which I don't see what's wrong with it? is it supposed to be more compact or something?

@JohnFulpWillard
Copy link
Contributor Author

Hitting Reconnect also does make an attempt at connecting you so it's not broken or anything.

image

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will continue to have testmerged for another week maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github changes to the .github folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants