Feat/local bucket development #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for multiple storage buckets and simplified the storage package by consolidating R2-specific code into a generic S3-compatible implementation. Environment variables were standardized and unused fields removed.
The commit swaps out goccy/go-json for bytedance/sonic JSON library, makes env vars required, and fixes storage URL paths.
The commit includes new domain model for files and interfaces for file operations in the usecase layer.
Since this commit introduces file handling with both public and private S3 storage support, including handlers, repository, and use case implementations, a slightly longer description in the body is warranted to capture the key components added. Add file upload functionality with S3 storage support Implements complete file handling flow with: - File upload handlers for public/private storage - File repository for persistence - File use case with S3 storage integration - Support for file listing and info retrieval
The changes appear to be a file relocation and build path updates. The main server code was moved from cmd/server/main.go to the root directory, with corresponding updates to build commands in Makefile and air.toml.
The build job now depends on successful swagger, lint and test jobs. Swagger docs are generated first and shared between jobs using artifacts, preventing redundant generation.
The workflow now includes proper caching, dependency cleanup and installation steps. Added debugging output to help troubleshoot build failures.
This reverts commit 7e2c13e.
This reverts commit 4e2cebc.
Since the changes involve restructuring the CI workflow into discrete jobs with proper dependencies and artifact sharing between jobs, I'm including a body to explain the key changes. The key changes include: - Splitting monolithic job into separate test/lint/build jobs - Adding artifact upload/download for swagger docs - Establishing proper job dependencies - Removing test from build job
and use omitempty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to add file management capabilities, update dependencies, and improve code structure. The most significant changes include the addition of file-related functionalities, updates to the Docker setup, and the introduction of new dependencies.
File Management Enhancements:
Filemodel to the database migration incmd/migrate/main.go.cmd/server/main.goto include new file-related use cases, repositories, and handlers. [1] [2]cmd/server/main.go.Docker and Environment Configuration:
.env.exampleto include new environment variables for private and public buckets.docker-compose.yml.Dependency Updates:
go-jsonwithsonicingo.mod.go.mod. [1] [2] [3]Code Refactoring:
BookPresentertobookDtoand implementedBookDtointerface ininternal/adaptor/dto/book_presenter.go.Documentation:
docs/docs.go,docs/swagger.json,docs/swagger.yaml). [1] [2] [3]