Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First there was a typo in the
Running without Anki
session in the Readme for linux systems. It's~/.local/
instead of~/local
(as indicated in the code and as XDG default)Second... I was trying to run it without anki and weirdly encountered errors as it seems to have found the wrong directory:
I realized the detection logic is flawed, as I somehow have anki's
aqt
package installed as my system package, which is carried over even when I usedpython -m venv ./venv
to create a virtual env for this repo. So the code would always think I'm inside anki and use the wrong directory.I think introducing a seperate env var
WO_ANKI
is a good solution (open to better names). It's won't affect the current plugin users. And it won't affect those who already got it working standalone either because it means they don't have aqt installed.