Allow specifying exact pitch values in pitch dicts - #2055
Merged
Conversation
Member
Author
|
This should be good to go now. |
jamesmaa
approved these changes
Jul 3, 2025
rampaa
added a commit
to rampaa/JL
that referenced
this pull request
Jul 3, 2025
…tion See: yomidevs/yomitan#2055 The current implementation does not support non-standard pitch patterns, and there are (at least for now) no plans to add support for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current pitch downstep format disallows certain nonstandard pitches and words/phrases with multiple downsteps.
One obvious but wrong idea to fix this may be to simply allow multiple downsteps. This falls apart when trying to handle both odaka or nakadaka pitches and something non-standard like HLHHL. To cover all bases, dictionary creators must be allowed to specify exactly where they want to high and low pitches.
Test dictionary (search

打ち込む): valid-dictionary1.zipExample of this pitch format in a dictionary:
Currently using
-1for the pitch position display and handlebar if there is no downstep. And the pitch category handlebar helper will return null in this case.