Skip to content

Allow specifying exact pitch values in pitch dicts - #2055

Merged
Kuuuube merged 10 commits into
yomidevs:masterfrom
Kuuuube:double-pitch
Jul 3, 2025
Merged

Allow specifying exact pitch values in pitch dicts#2055
Kuuuube merged 10 commits into
yomidevs:masterfrom
Kuuuube:double-pitch

Conversation

@Kuuuube

@Kuuuube Kuuuube commented Jun 18, 2025

Copy link
Copy Markdown
Member

The current pitch downstep format disallows certain nonstandard pitches and words/phrases with multiple downsteps.

One obvious but wrong idea to fix this may be to simply allow multiple downsteps. This falls apart when trying to handle both odaka or nakadaka pitches and something non-standard like HLHHL. To cover all bases, dictionary creators must be allowed to specify exactly where they want to high and low pitches.

Test dictionary (search 打ち込む): valid-dictionary1.zip
image

Example of this pitch format in a dictionary:

"pitches": [
    {"position": "HLHL"}
]

Currently using -1 for the pitch position display and handlebar if there is no downstep. And the pitch category handlebar helper will return null in this case.

@Kuuuube
Kuuuube requested a review from a team as a code owner June 18, 2025 05:01
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/dictionary-format The issue or PR is related to dictionary formatting labels Jun 18, 2025
@Kuuuube

Kuuuube commented Jun 29, 2025

Copy link
Copy Markdown
Member Author

This should be good to go now.

@Kuuuube
Kuuuube added this pull request to the merge queue Jul 3, 2025
Merged via the queue into yomidevs:master with commit d128808 Jul 3, 2025
25 checks passed
@Kuuuube
Kuuuube deleted the double-pitch branch July 3, 2025 17:34
rampaa added a commit to rampaa/JL that referenced this pull request Jul 3, 2025
…tion

See: yomidevs/yomitan#2055

The current implementation does not support non-standard pitch patterns, and there are (at least for now) no plans to add support for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dictionary-format The issue or PR is related to dictionary formatting kind/enhancement The issue or PR is a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants