Skip to content

Conversation

@Manhhao
Copy link

@Manhhao Manhhao commented Sep 22, 2025

This was suggested on Discord and I thought it'd be pretty cool. Especially useful on ereaders and would make scrolling through definitions on higher quality modes feel a lot better.

It doesn't exactly scroll by popup height, there is a small overlap to kind of help with orientation.

I wasn't sure where to place the checkbox, so it's currently under "Popup Behaviour" as an advanced option.

scroll.mp4

@Manhhao Manhhao requested a review from a team as a code owner September 22, 2025 18:34
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

@Manhhao Manhhao changed the title Add paginated scrolling to popup Add paginated scrolling option Sep 22, 2025
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design area/settings This issue or PR is related to settings. labels Sep 23, 2025
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mention in the setting description that it's useful for e-readers or e-ink displays.

Also not sure I like the name of this setting. Are there other programs that also call this type of thing paginated scrolling?

@Manhhao
Copy link
Author

Manhhao commented Sep 23, 2025

I don't like the name much either, but I also couldn't come up with a different name. If I were to make the jump amount configurable, something like "Scroll override" could work? Other programs just call this pagination, but this isn't really true pagination.

E: This is apparently called "Scrolling by a screenful", so something like "Screenful scrolling" could also work?

@Kuuuube
Copy link
Member

Kuuuube commented Sep 23, 2025

"Screenful scrolling" sounds even worse.

How about "Reduced motion scrolling"? If "Paginated Scrolling" is a common term for this maybe note that in the setting description so it can be found with ctrl+f. Along with my previous suggestion about mentioning this setting can help on e-readers.

@Manhhao
Copy link
Author

Manhhao commented Sep 23, 2025

That sounds good, I'll push my changes tomorrow.

@Manhhao Manhhao changed the title Add paginated scrolling option Add "Reduced motion scrolling" option Sep 25, 2025
@Manhhao
Copy link
Author

Manhhao commented Sep 25, 2025

I've updated the name, description and also exposed both magic numbers as user options. I've also added descriptions to both options. Let me know if anything needs changes.

@Manhhao Manhhao requested a review from Kuuuube September 25, 2025 13:14
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. One small thing, where you put (in pixels) can you instead put that as a label saying just px ontop of the input box? For reference, some settings such as Horizontal text offset use this styling.

@Manhhao Manhhao requested a review from Kuuuube September 25, 2025 21:09
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@Kuuuube Kuuuube added this pull request to the merge queue Sep 25, 2025
Merged via the queue into yomidevs:master with commit 972535f Sep 26, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/settings This issue or PR is related to settings. area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants