-
Notifications
You must be signed in to change notification settings - Fork 194
Add "Reduced motion scrolling" option #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kuuuube
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should mention in the setting description that it's useful for e-readers or e-ink displays.
Also not sure I like the name of this setting. Are there other programs that also call this type of thing paginated scrolling?
|
I don't like the name much either, but I also couldn't come up with a different name. If I were to make the jump amount configurable, something like "Scroll override" could work? Other programs just call this pagination, but this isn't really true pagination. E: This is apparently called "Scrolling by a screenful", so something like "Screenful scrolling" could also work? |
|
"Screenful scrolling" sounds even worse. How about "Reduced motion scrolling"? If "Paginated Scrolling" is a common term for this maybe note that in the setting description so it can be found with ctrl+f. Along with my previous suggestion about mentioning this setting can help on e-readers. |
|
That sounds good, I'll push my changes tomorrow. |
|
I've updated the name, description and also exposed both magic numbers as user options. I've also added descriptions to both options. Let me know if anything needs changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. One small thing, where you put (in pixels) can you instead put that as a label saying just px ontop of the input box? For reference, some settings such as Horizontal text offset use this styling.
Kuuuube
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
This was suggested on Discord and I thought it'd be pretty cool. Especially useful on ereaders and would make scrolling through definitions on higher quality modes feel a lot better.
It doesn't exactly scroll by popup height, there is a small overlap to kind of help with orientation.
I wasn't sure where to place the checkbox, so it's currently under "Popup Behaviour" as an advanced option.
scroll.mp4