Skip to content

Conversation

@9mdv
Copy link

@9mdv 9mdv commented Nov 8, 2025

This will move the two advanced settings (search window, translation) to the bottom of the list so you can easily see which were toggled, improving the user experience.

@9mdv 9mdv requested a review from a team as a code owner November 8, 2025 02:02
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 8, 2025

CodSpeed Performance Report

Merging #2238 will improve performances by ×2.4

Comparing 9mdv:reorder-sidebar-items (caea940) with master (1eecf11)

Summary

⚡ 4 improvements
✅ 1 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
japanese transformations (n=78) 17.8 ms 8.3 ms ×2.2
japanese transformations-full (n=212) 47.3 ms 22.4 ms ×2.1
spanish transformations (n=97) 15.2 ms 6.4 ms ×2.4
Translator.prototype.findTerms - (n=45) 193.8 ms 113.4 ms +71.01%

@Kuuuube
Copy link
Member

Kuuuube commented Nov 17, 2025

I've thought about this a bit since I'm not totally convinced this is entirely good. I would like to keep the settings nicely ordered rather than splitting off advanced categories. What do you think about adding an accent to the advanced categories similar to how it works for settings?

For example, you can see the little purple bar on the right side of the advanced setting and nothing on the basic setting:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants