Make glossary-plain structured gloss to raw string conversion recursive #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmaa
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix another case in #2212
Just one more patch bro it's fixed for real this time bro believe me just one more patch cmon just merge this one patch and we wont have to worry about any more problems with this again for sure real believe me#2240 made the glossary extraction recursive to ensure ordering did not get messed up there. But ordering could still get messed up in the conversion from glossary to raw string. This fixes that by making that part recursive as well.
This could probably be rolled all into a single function rather than two distinct steps but I don't want to worry about testing that at the moment and there's no real problems doing it this way. It's the same amount of compute, just some small extra allocation.