-
Notifications
You must be signed in to change notification settings - Fork 194
add option to group by term #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to group by term #2258
Conversation
|
Check that this doesnt break glossary handlebars if you havent already. Theres some logic that changes when grouping changes. |
|
Shouldn't be a problem there, it uses the existing termGrouped |
|
This seems like a very awaited change, at least for me as a user. |
|
This should be ready now. The headword-reading pairs should sort by dictionary index, as @username-011 mentioned.
Maybe, but I would leave it as-is for now, since removing it might break something else. |
Kuuuube
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This option allows grouping entries with missing readings, or different readings, primarily for non-ja languages.