Skip to content

Conversation

@StefanVukovic99
Copy link
Member

This option allows grouping entries with missing readings, or different readings, primarily for non-ja languages.

Before After
Screenshot from 2025-12-02 16-53-16 Screenshot from 2025-12-02 16-54-23

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner December 2, 2025 16:16
@Kuuuube
Copy link
Member

Kuuuube commented Dec 2, 2025

Check that this doesnt break glossary handlebars if you havent already. Theres some logic that changes when grouping changes.

@StefanVukovic99
Copy link
Member Author

Shouldn't be a problem there, it uses the existing termGrouped

@StefanVukovic99 StefanVukovic99 marked this pull request as draft December 2, 2025 17:10
@username-011
Copy link

username-011 commented Dec 2, 2025

This seems like a very awaited change, at least for me as a user.
If possible, I think it would be even more useful if the terms order after grouping respected the order of the dictionaries that they came from (not sure if that's the case on the screenshot above), will be useful for languages where there are multiple possible readings, but one is from a popular dictionary (shown to the top) vs more rare/old/regional dictionaries (where you need to scroll down).
Also maybe no need to show the term with no readings when there are 2+ terms?

@StefanVukovic99 StefanVukovic99 marked this pull request as ready for review December 10, 2025 17:27
@StefanVukovic99
Copy link
Member Author

This should be ready now. The headword-reading pairs should sort by dictionary index, as @username-011 mentioned.

no need to show the term with no readings

Maybe, but I would leave it as-is for now, since removing it might break something else.

Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Kuuuube Kuuuube added the kind/enhancement The issue or PR is a new feature or request label Dec 13, 2025
@Kuuuube Kuuuube added this pull request to the merge queue Dec 13, 2025
@Kuuuube Kuuuube added area/ui-ux The issue or PR is related to UI/UX/Design area/settings This issue or PR is related to settings. labels Dec 13, 2025
Merged via the queue into yomidevs:master with commit 2f8ee50 Dec 13, 2025
25 of 26 checks passed
@StefanVukovic99 StefanVukovic99 deleted the group-by-term-option branch December 13, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/settings This issue or PR is related to settings. area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants