Fix: Unable to select text inside blob

[dlip]

Fixes #2457

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 965c0bddc7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Bump Firefox minimum for this key

This adds match_origin_as_fallback to the Firefox variants while the same generated manifest still advertises browser_specific_settings.gecko.strict_min_version and gecko_android.strict_min_version as 115.0; Firefox only supports this content-script key starting in 128. On Firefox/Firefox Android 115–127 the extension is still considered compatible, but the new blob/data/about injection behavior is unsupported, so the reported blob-reader scenario remains broken for part of the declared support range unless the minimum version is raised or an older-version fallback is used.

Useful? React with 👍 / 👎.

[Kuuuube]

Is there a reason you added this as a modification to half the manifest variants instead of modifying the base manifest

[dlip]

@Kuuuube I was worried about Safari since I couldn't test it, but on further googling it seems fine. I added it to the base

[dlip]

@Kuuuube I fixed the unit test, could you please run the workflow again?

[Kuuuube]

The @types/chrome package needs to be bumped.

Also if you want to do a full update on the chrome-manifest-schema.json file, can just copy this in: https://raw.githubusercontent.com/cezaraugusto/chrome-extension-manifest-json-schema/refs/heads/main/manifest/manifest.schema.v3.json.

[dlip]

@Kuuuube I updated the chrome-manifest-schema.json, but upgrading @types/chrome broke a lot of things so I just made a minimal patch to the type so the test would pass

[Kuuuube]

Are you sure you only bumped @types/chrome? And you ran npm install & npm ci after? I did give that a quick test before suggesting it and it should work.

[dlip]

@Kuuuube the errors occur with npm run test:ts:main

Errors  Files
     1  ext/js/background/backend.js:478
     1  ext/js/background/script-manager.js:125
     1  ext/js/display/search-display-controller.js:597
     1  ext/js/extension/environment.js:61
     4  ext/js/pages/settings/anki-controller.js:1213
     2  ext/js/pages/settings/permissions-toggle-controller.js:89
     1  ext/js/pages/settings/recommended-permissions-controller.js:85

[dlip]

@Kuuuube I bumped @types/chrome and fixed the errors, let me know if you want to keep it or not

[Kuuuube]

Thanks for bumping that. Looks good. Just one small suggestion.

Looks like npm is down maybe. I'll rerun the tests later.

[Kuuuube]

Im going to need you to explain why in the package lock you've edited the source of a package to point away from the official npm registry into a third party private npm listing.

I can give you a pass on it not being malicious since the hash is intact but that is super sketchy.

(This is why tests are failing btw)

Also I dont think any of these packages should be peer dependencies? Unless I'm misunderstanding what that means in npm.

[dlip]

@Kuuuube Yes, sorry about the package lock thing, I have an internal private registry set up in my npm config and it seems to have decided to prioritize that. It's not accessible externally, but I agree it was a good idea for you to raise it since it might have been malicious. I cleaned it out and squashed my changes to be sure its not used.