Skip to content

Conversation

@lennet
Copy link

@lennet lennet commented Apr 20, 2019

This PR adds two commands:

  • outdated: returns all linked packages that are not up to date
  • update: reinstall all outdated packages

fixes #87, #121

}

func resolvePackage(_ package: PackageReference) throws {
func resolvePackage(_ package: PackageReference, silent: Bool = false) throws {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy with that solution to silent the method.. Maybe it would be cleaner to inject output. as. an optional parameter into the functions?

return
}
for (name, value) in outdatedPackages {
try install(package: value.newReference, executable: name, force: true, link: true)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if I need to provide the executable name here

@yonaskolb
Copy link
Owner

Hi @lennet. Thanks for the PR, they are some great additions! I’m on holidays somewhere remote till the 30th so won’t have time to look at this properly till then.
Without having gone through this, one question I would ask is does this play well with Mintfiles? I could imagine if someone ran this in a directory with a mintfile they would expect the outdated to list updates to what packages they have specified

@lennet
Copy link
Author

lennet commented May 1, 2019

Hope you had great holidays! Yes, currently these command only check linked packages. Should I include packages that are installed via a Mintfile in the same command or add a separate command or argument for it?

@swiftcrossing
Copy link

Hi @yonaskolb. These additions look very promising, and I’m sure would be a welcome addition to mint by the community. Have you had a chance to look at this PR recently? Is there anything one could do to get it into a merge-ready state?

@bdrelling
Copy link

@yonaskolb I recently submitted an issue (#174) and the happened to check what the open PRs are for here. Whatever happened with this?

@MartinP7r
Copy link
Contributor

Sorry to dig this up again, but it looks like this PR was forgotten?
@yonaskolb I'm sure you're very busy and maintaining several os projects is taking a lot of time as well, but could you have a look or delegate the review tasks to someone?

@AF-cgi AF-cgi mentioned this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package upgrading routine is currently unintuitive

5 participants