Git Submodule Support #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be great for our use case too! |
There was a problem hiding this comment.
Pull request overview
This PR adds git submodule support to Mint, enabling the installation of packages that depend on submodules, such as apple/swift-protobuf. The change adds the --recurse-submodules flag to git clone and checkout operations to ensure submodules are properly initialized during package installation.
- Adds
--recurse-submodulesflag to git clone and checkout commands - Supports both SHA-based and shallow clone scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks @Brett-Best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds git submodule support, this allows Mint to install https://github.com/apple/swift-protobuf.
I considered adding this to the tests but it would increase how long they take to run substantially.
I've left
Allow edits by maintainerson so you can tweak this if needed @yonaskolb 😄