Support multi-user undo and redo #640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyemmie
added
enhancement 🌟
Contributor
Author
|
This draft PR was replaced by the PR #644. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Modification of the protocol buffer is required to test the multi-user undo and redo feature being developed in the js-sdk(yorkie-team/yorkie-js-sdk#635). This change is necessary to test the
pushPullChangesfunction without errors when the new operation(EditReverse) is added, but this draft PR does not need to be merged immediately. The js-sdk test was done by building a separate docker image locally and this draft PR is only used to mention testable conditions within comments in the js-sdk source code.Which issue(s) this PR fixes:
Fixes #49
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: