Allow to dynamically skip a field by returning SKIP #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great if there exists some kind of documentation or reference of this feature. I discovered it by luck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm trying to convert one of our app that uses AMS 0.9 (Shopify/shipit-engine#1139), but one missing feature the the possibility of skipping an attribute.
I've read #16 and I understand the performance concern, however I think it can be done efficiently.
This PR
It define a special value
Panko::Serializer::SKIP, if a serializer field returns it, the field is not serialized. The performance overhead should be totally negligible.