Conversation
3f9941f to
d952be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ubuntu 22.04 Support
Summary
This PR adds support for installing Sourcery on Ubuntu 22.04 LTS systems.
Changes
lib/utils.bashAdded
get_platform()- Detects the current platform by checkinguname -sand parsing/etc/os-releaseon Linuxmacosfor Darwin systemsubuntu-22.04for Ubuntu 22.04 systemsAdded
get_ubuntu_asset_url()- Dynamically fetches the Ubuntu release asset URL from the GitHub APIuname -m(supportsx86_64,aarch64)*ubuntu*22.04*{arch}*.tar.xzbrowser_download_urlfrom the release assetsUpdated
download_release()- Uses platform-specific download URLs:sourcery-{version}.zipbin/download.zipvs.tar.xz)unziptar -xf.github/workflows/build.ymlmacos-latestandubuntu-22.04Why Dynamic URL Resolution?
The Ubuntu asset naming varies across Sourcery releases (e.g.,
ubuntu-22.04.4in 2.2.5 vsubuntu-22.04.5in 2.2.6). Instead of hardcoding the asset name, we query the GitHub API to find the correct download URL for each version.Limitations
Testing