Open
Conversation
cometj03
reviewed
Jan 12, 2025
Comment on lines
+139
to
+142
| val bottomBarVerticalOffset = layoutHeight - bottomBarPlaceable.height | ||
| val fabVerticalOffset = | ||
| bottomBarVerticalOffset - fabPlaceable.height - fabBottomMarginPxValue | ||
| val snackBarVerticalOffset = fabVerticalOffset - snackBarPlaceable.height - snackBarPxValue |
Member
There was a problem hiding this comment.
fab이 없을 땐 fabVerticalOffset이 bottomBarVerticalOffset과 같아야 할 것 같아요.
쉽게 설명하자면 지금 상황에서 fab이 없을 때 snackBar가 어디에 배치될지 생각해보심 됩니다. 아마 생각보다 높은 곳에 배치될거예요. (fab 마진 + snackBar 마진 만큼)
Member
There was a problem hiding this comment.
@kangyuri1114
업데이트 해주신 프리뷰 확인했어요. 근데 FAB랑 SnackBar가 같이 있는 경우에는 SnackBar가 FAB 위에 그려지는 게 맞지 않을까요? 가장 처음에 첨부해주신 프리뷰처럼요
cometj03
reviewed
Apr 8, 2025
|
|
||
| val snackBarPlaceable = subcompose(ScaffoldLayoutContent.Snackbar) { | ||
| Box(modifier = Modifier | ||
| .padding() |
Member
There was a problem hiding this comment.
이거 padding(horizontal = 0.dp, vertical = 0.dp)랑 같은거 맞을까요? 그렇다면 없어도 될 것 같습니다!
leeeyubin
reviewed
Apr 8, 2025
Comment on lines
+160
to
+164
| object ScaffoldSpacingValues { | ||
| val FabBottomSpacing = 32.dp | ||
| val FabEndSpacing = 16.dp | ||
| val SnackBarBottomSpacing = 16.dp | ||
| } |
Member
There was a problem hiding this comment.
ScaffoldLayoutContent 이넘클래스는 private인데 ScaffoldSpacingValues는 아닌 이유가 궁금해졌어요...!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
Scaffold 구현
Preview 사진
아직 component들이 구현 중이라 색상으로 대체했습니다.
구성요소
옵션 설명
그려지는 순서
semantic의 traversalIndex값이 작은 순서대로
topBar -> bottomBar -> content -> FAB -> snackBar
*padding값
화면에서의 padding values -> object로 관리
snackBar : horizontal 16.dp, bottom 16.dp
FAB : end 16.dp, bottom 32.dp
(SnackBar가 FAB보다 상단에 있어야 함)
2025.04.08 업데이트