Open
Conversation
| .padding(20.dp), | ||
| verticalArrangement = Arrangement.spacedBy(20.dp) | ||
| ) { | ||
| val (text, onValueChange) = remember { androidx.compose.runtime.mutableStateOf("") } |
Contributor
There was a problem hiding this comment.
요거만 임포트해서 줄여주시면 좋을거 같습니다
| modifier = Modifier.wrapContentSize().padding(20.dp), | ||
| verticalArrangement = Arrangement.spacedBy(20.dp) | ||
| ) { | ||
| val (text, onValueChange) = remember { androidx.compose.runtime.mutableStateOf("") } |
cometj03
reviewed
Jan 19, 2025
Comment on lines
+48
to
+56
|
|
||
| Row( | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .clip(RoundedCornerShape(12.dp)) | ||
| .background(HandyTheme.colors.bgBasicLight) | ||
| .border(1.dp, borderColor, RoundedCornerShape(12.dp)) | ||
| .padding(start = 16.dp, end = 12.dp, top = 12.dp, bottom = 12.dp) | ||
| ) { |
Comment on lines
+105
to
+110
| @Composable | ||
| fun getTextFieldStyle( | ||
| enabled: Boolean, | ||
| isError: Boolean, | ||
| isFocused: Boolean | ||
| ): TextFieldStyle { |
Member
There was a problem hiding this comment.
TextFieldStyle의 접근 지정자를 public으로 두신 이유가 있을까요? internal이나 private이어도 될 것 같아서요.
이 함수는 외부에서 사용될 함수가 아니라면 internal이나 private로 해주시면 좋을 것 같습니다.
Member
Author
There was a problem hiding this comment.
접근 지정자를 빼먹었던 것 같아요! 반영했습니다~
Comment on lines
+81
to
+83
| trailingIcon?.let { | ||
| Icon( | ||
| imageVector = trailingIcon, |
Member
There was a problem hiding this comment.
Suggested change
| trailingIcon?.let { | |
| Icon( | |
| imageVector = trailingIcon, | |
| trailingIcon?.let { | |
| Icon( | |
| imageVector = it, |
it으로 하는 게 통일성 있을 것 같아요
| interactionSource = interactionSource, | ||
| onClick = onClickTrailingIcon | ||
| ) | ||
| .padding(start = 12.dp) |
Member
There was a problem hiding this comment.
padding보다는 Spacer가 명시적이어서 나을 것 같긴 한데 어떻게 생각하시나요?
Member
Author
There was a problem hiding this comment.
좋은 것 같아요! 위에 it도 그렇고 이부분도 가이드로 통일하면 좋을 것 같아 다른 컴포넌트들도 반영해볼게요~
Member
There was a problem hiding this comment.
그러면 TextArea는 별도의 PR로 올려주시고 여기서는 제외하는 게 좋을 것 같습니다!
Comment on lines
+12
to
+13
| import com.yourssu.handy.compose.foundation.HandyTypography | ||
| @Composable |
leeeyubin
reviewed
Jan 19, 2025
Comment on lines
+49
to
+54
| Row( | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .clip(RoundedCornerShape(12.dp)) | ||
| .background(HandyTheme.colors.bgBasicLight) | ||
| .border(1.dp, borderColor, RoundedCornerShape(12.dp)) |
Member
There was a problem hiding this comment.
여기두 Radius.M.dp 사용할 수 있지 않을까요..?!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handy Component로는 TextField가 사용되고 여러 TextField 구현을 위해 OutlinedTextField를 구현했습니다
제가 다음주 개발이 불가능해서 미리 올리고 코드리뷰 받아두는 게 시간상 좋을 것 같아 textArea 개발 전에 textField 먼저 올립니다.
_2025_01_19_19_35_56_498.mp4