android: Move AudioTrackBridge array allocation to Java to avoid direct env->New* calls#10780
android: Move AudioTrackBridge array allocation to Java to avoid direct env->New* calls#10780kjyoun wants to merge 1 commit into
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors audio buffer allocation by moving the pre-allocation of the audio data array from C++ to Java within AudioTrackBridge. The pre-allocated array is then retrieved in C++ via JNI. Feedback on this change highlights a potential issue where throwing a RuntimeException from a JNI-invoked constructor for an unsupported sample type can lead to undefined behavior or crashes. It is recommended to log an error and let the C++ side handle the resulting null reference gracefully.
…ew* calls To follow best practices and reduce the risk of memory leaks from un-wrapped local references, this change moves the allocation of the audio data array from C++ to Java. - AudioTrackBridge in Java now allocates the mAudioData array in its constructor. - The C++ side calculates the required max_samples_per_write and passes it to Java during creation. - C++ retrieves the allocated array reference using getAudioData() getter. - Reordered parameters in CreateAudioTrackBridge to group max_samples_per_write with format-related parameters. BUG=b/520007952 TAG=agy CONV=5d7aa66e-ca8b-4eab-bf9f-38fb21320b8c
There was a problem hiding this comment.
Code Review
This pull request refactors the audio data buffer allocation in AudioTrackBridge. The allocation of the JNI audio data array is moved from the C++ side to the Java side during construction, using a new maxSamplesPerWrite parameter. The C++ side then retrieves this pre-allocated array via a new JNI method getPreAllocatedAudioData(). I have no feedback to provide as there are no review comments.
1 participant
Move the allocation of audio data buffers from C++ JNI calls to the
Java AudioTrackBridge constructor.
This change follows JNI best practices by avoiding direct calls to
memory allocation methods in the JNI environment, which reduces the
risk of memory leaks from un-wrapped local references. The Java side
now manages the buffer lifecycle, and the C++ layer retrieves the
reference during initialization.
Issue: 520007952