android: Replace env->NewGlobalRef with NoDestructor wrapper

[kjyoun]

• Refactor starboard/android/shared/video_window.cc to replace direct env->NewGlobalRef call with starboard::NoDestructor<jni_zero::ScopedJavaGlobalRef>.
• This ensures safe lifecycle management of the global video surface JNI reference and avoids potential shutdown crashes.
• Add starboard::NoDestructor utility to starboard/common, mirroring base::NoDestructor.
• Add unit tests for starboard::NoDestructor in no_destructor_test.cc.

Issue: 520007952
Issue: 509619283

[github-actions]

🤖 Gemini Suggested Commit Message

---

android: Use NoDestructor for JNI video surface

Refactor the Android video window implementation to use a NoDestructor
wrapper around ScopedJavaGlobalRef for the video surface. This ensures
safe lifecycle management of the JNI reference and prevents potential
shutdown crashes associated with static destructors.

This change also introduces the starboard::NoDestructor utility to
starboard/common, mirroring base::NoDestructor, along with unit tests.

Issue: 520007952
Issue: 509619283

---

💡 Pro Tips for a Better Commit Message:

1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
2. Re-run the Generator: Post a comment with: /generate-commit-message

[kjyoun]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a NoDestructor<T> utility class to prevent the execution of non-trivial destructors for static and global variables, accompanied by comprehensive unit tests. Additionally, it refactors the global video surface management in video_window.cc to utilize jni_zero::ScopedJavaGlobalRef wrapped in NoDestructor. The review feedback recommends using std::launder in NoDestructor::get() to comply with C++17 strict aliasing rules and prevent undefined behavior. It also suggests simplifying the JNI reference resetting logic in video_window.cc since ScopedJavaGlobalRef::Reset automatically handles releasing the previous reference.

[gemini-code-assist]

Code Review

This pull request introduces a NoDestructor helper class to starboard/common along with its unit tests, and utilizes it in video_window.cc to manage a global Java reference safely using jni_zero::ScopedJavaGlobalRef. The feedback suggests simplifying the video surface reset logic by removing a redundant null check, as Reset() is safe to call on empty references.