Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"MessageTest.DestructInvalidMessageHandle",
"NullTraceWriterDeathTest.NewTracePacketTakeStreamWriterNoFinish",
"ScopedDirTest.CloseOutOfScope",
"UtilsTest.EintrWrapper"
"UtilsTest.EintrWrapper",
"FuchsiaTraceParserTest.FxtWithProtos"
]
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"comment": "Temporarily disable tests in NavigationBrowserTest. See b/433354983.",
"failing_tests": [
"All/CobaltMemoryThresholdBrowserTest.BlankPageMemoryFootprint/0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tasunnn Please take a look. If the flakiness cannot be mitigated, gardener may disable these tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linxinan-chops and I were only able to find one failure for CobaltMemoryThresholdBrowserTest.BlankPageMemoryFootprint test - https://github.com/youtube/cobalt/actions/runs/26681674436/job/78644679112. Looking at the logs, I think it's a race condition due to browser test setup rather than the test itself. @arjungm do you see any other failures related to this specific test? If not, I think we could keep this test enabled? Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, will undo this one (turns out the flaky detector itself flaked on this one hah)

"*CobaltMetricsBrowserTest*",
"*DeferSpeculativeRFHCreationRenderProcessTest*",
"*NavigationBrowserTestDeprecateUnloadOptOut*",
Expand Down
Loading