Skip to content

cobalt: Disable HSTS Preload List#10792

Open
borongc wants to merge 1 commit into
youtube:mainfrom
borongc:unused_assert
Open

cobalt: Disable HSTS Preload List#10792
borongc wants to merge 1 commit into
youtube:mainfrom
borongc:unused_assert

Conversation

@borongc
Copy link
Copy Markdown
Contributor

@borongc borongc commented Jun 7, 2026

Disable the HSTS (HTTP Strict Transport Security) preloaded list
to reduce binary size. This change saves approximately 1.3 MB of
read-only data. Cobalt is a closed app shell and does not require
the comprehensive list of third-party domains provided by Chromium.

# original
> du -s out/android-arm_qa/libchrobalt.so
70748	out/android-arm_qa/libchrobalt.so
> du -s out/android-arm_qa/apks/Cobalt.apk
89472	out/android-arm_qa/apks/Cobalt.apk
> du -s out/evergreen-arm-hardfp-rdk_qa/libcobalt.so
78992	out/evergreen-arm-hardfp-rdk_qa/libcobalt.so

# include_transport_security_state_preload_list = false
> du -s out/android-arm_qa/libchrobalt.so
69452	out/android-arm_qa/libchrobalt.so
> du -s out/android-arm_qa/apks/Cobalt.apk
88176	out/android-arm_qa/apks/Cobalt.apk
> du -s out/evergreen-arm-hardfp-rdk_qa/libcobalt.so
78992	out/evergreen-arm-hardfp-rdk_qa/libcobalt.so

Issue: 520903111

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 7, 2026

🤖 Gemini Suggested Commit Message


build: Disable HSTS preload list

Disable the HSTS preloaded list to reduce binary size. This change
saves approximately 1.3 MB of read-only data. Cobalt is a closed
app shell and does not require the comprehensive list of third-party
domains provided by Chromium.

Issue: 520903111

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the HSTS preload list in cobalt/build/configs/common.gn to reduce binary size. The reviewer pointed out that disabling a feature for binary size optimization must follow the surgical feature removal pipeline and guidelines documented in SKILL.md, which this PR currently lacks.

Comment thread cobalt/build/configs/common.gn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant