Rename switch defaults src to state it's for linux #6046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the situation where devs will change the defaults here, and assume other platforms will get the same behavior (e.g. Android). This is a workaround because getting switch defaults to be synced via a single source of truth is not currently feasible. b/397982418
yell0wd0g
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Changes makes sense but I wonder if we should name this
new file _linux.cc or _posix.cc? @andrewsavage1 for
opinions.
It seems like it should be _starboard.cc It also seems like this should not be in a target common to android and linux builds right now, and instead just be built for the linux build. |
johnxwork
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the situation where devs will change the defaults here, and assume
other platforms will get the same behavior (e.g. Android). This is a workaround
because getting switch defaults to be synced via a single source of truth is not
currently feasible.
Bug: 397982418