[WIP] Add tzset using ICU and tests. #6048
Draft
+1,959
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellefoks
changed the title
jellefoks
force-pushed
the
add_timezone_tzset_and_tests
branch
5 times, most recently
from
2455ee5 to
a0754e3
Compare
jellefoks
force-pushed
the
add_timezone_tzset_and_tests
branch
2 times, most recently
from
a28d492 to
7440dd7
Compare
jellefoks
force-pushed
the
add_timezone_tzset_and_tests
branch
3 times, most recently
from
e8c09a9 to
8460dca
Compare
This adds tzset(). This POSIX functions sets the values of the tzname, timezone, and daylight globals from the TZ environment variable. This is implemented using our ICU's tzdata with fallback to POSIX compliant parsing where ICU is unable to recognize the format of the TZ variable. Some corrections are done for certain timezones, necessary since our tzdata is version 2023c. A helper function is added for parsing the POSIX format for the TZ value. ICU is initialized early with a global static bool, so that it is initialized even without using //base. Also add extensive tests. Many tests are excluded for non-hermetic builds because they set incorrect values. Bug: 406082846
jellefoks
force-pushed
the
add_timezone_tzset_and_tests
branch
from
8460dca to
8bc6d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tzset(). This POSIX functions sets the values of the tzname,
timezone, and daylight globals from the TZ environment variable.
This is implemented using our ICU's tzdata with fallback to POSIX
compliant parsing where ICU is unable to recognize the format of the TZ
variable.
Some corrections are done for certain IANA timezones, necessary since our
tzdata is currently version 2023c.
A helper function is added for parsing the POSIX format for the TZ value.
ICU is initialized early with a global static bool. That way it is
always initialized, even without using //base.
Also add extensive tests. Many tests are excluded for non-hermetic
builds because they set incorrect values.
Bug: 406082846