-
Notifications
You must be signed in to change notification settings - Fork 149
Add evergreen raspi build config #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
27e8d69
to
5fe9c64
Compare
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Raspberry Pi build configuration to a new 'evergreen' version. This involves renaming the configuration file from .github/config/raspi.json
to .github/config/evergreen-raspi-arm-hardfp.json
and updating platform identifiers within it. These changes seem to align well with the stated goal of adding CI actions for an evergreen raspi build and removing the old ones.
One general question regarding the overall change: The docker_service
field (line 2 of the new file) remains "raspi"
. With the transition to an 'evergreen' setup, was there any consideration to update this field? Is "raspi"
still the correct and intended service identifier for this new configuration, or should it perhaps also reflect the 'evergreen' aspect or a more specific version if the underlying Docker service context has changed? (Note: As this line isn't directly modified in the diff, this is a broader query about the configuration's completeness.)
Please see the specific review comment below regarding a naming detail within the includes
section.
Summary of Findings
- Potential Naming Inconsistency in Configuration: The
name
field within theincludes
section of theevergreen-raspi-arm-hardfp.json
configuration file is"raspi-arm-hardfp"
, while other related identifiers use the"evergreen-raspi-arm-hardfp"
naming. Clarification is requested to ensure this distinction is intentional and correct, as an oversight could lead to misconfiguration.
Merge Readiness
The PR makes a clear and targeted change to update the Raspberry Pi build configuration for an 'evergreen' system. However, there's one point regarding a naming convention within the JSON configuration (detailed in the review comment) that would benefit from clarification to ensure its accuracy. Addressing this point will help confirm the configuration's correctness before merging.
Therefore, I recommend clarifying the noted point. As a reviewer, I am not authorized to approve pull requests; please ensure this PR undergoes any further necessary reviews and approvals according to your team's policies before merging.
2fe940a
to
22b1ffa
Compare
08a68e2
to
17839ac
Compare
17839ac
to
f9b58e6
Compare
1584cd6
to
95f25c9
Compare
All comments addressed
95f25c9
to
c5771e9
Compare
c5771e9
to
84bd543
Compare
Issue: 412446243
Add CI actions for raspi evergreen build.
Remove CI actions for raspi build.