Skip to content

Add evergreen raspi build config #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Jun 9, 2025

Issue: 412446243

Add CI actions for raspi evergreen build.
Remove CI actions for raspi build.

@niranjanyardi niranjanyardi force-pushed the raspi_evergreen_ci branch 2 times, most recently from 27e8d69 to 5fe9c64 Compare June 10, 2025 00:03
@niranjanyardi
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Raspberry Pi build configuration to a new 'evergreen' version. This involves renaming the configuration file from .github/config/raspi.json to .github/config/evergreen-raspi-arm-hardfp.json and updating platform identifiers within it. These changes seem to align well with the stated goal of adding CI actions for an evergreen raspi build and removing the old ones.

One general question regarding the overall change: The docker_service field (line 2 of the new file) remains "raspi". With the transition to an 'evergreen' setup, was there any consideration to update this field? Is "raspi" still the correct and intended service identifier for this new configuration, or should it perhaps also reflect the 'evergreen' aspect or a more specific version if the underlying Docker service context has changed? (Note: As this line isn't directly modified in the diff, this is a broader query about the configuration's completeness.)

Please see the specific review comment below regarding a naming detail within the includes section.

Summary of Findings

  • Potential Naming Inconsistency in Configuration: The name field within the includes section of the evergreen-raspi-arm-hardfp.json configuration file is "raspi-arm-hardfp", while other related identifiers use the "evergreen-raspi-arm-hardfp" naming. Clarification is requested to ensure this distinction is intentional and correct, as an oversight could lead to misconfiguration.

Merge Readiness

The PR makes a clear and targeted change to update the Raspberry Pi build configuration for an 'evergreen' system. However, there's one point regarding a naming convention within the JSON configuration (detailed in the review comment) that would benefit from clarification to ensure its accuracy. Addressing this point will help confirm the configuration's correctness before merging.

Therefore, I recommend clarifying the noted point. As a reviewer, I am not authorized to approve pull requests; please ensure this PR undergoes any further necessary reviews and approvals according to your team's policies before merging.

@niranjanyardi niranjanyardi force-pushed the raspi_evergreen_ci branch 2 times, most recently from 2fe940a to 22b1ffa Compare June 10, 2025 21:56
@niranjanyardi niranjanyardi marked this pull request as ready for review June 10, 2025 23:57
@niranjanyardi niranjanyardi requested a review from a team as a code owner June 10, 2025 23:57
@niranjanyardi niranjanyardi force-pushed the raspi_evergreen_ci branch 2 times, most recently from 1584cd6 to 95f25c9 Compare June 12, 2025 01:38
@niranjanyardi niranjanyardi requested a review from briantting June 12, 2025 17:36
@niranjanyardi niranjanyardi enabled auto-merge (squash) June 12, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants