[POSIX] Add perror from musl to Chrobalt #6052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedocampo
changed the title
johnedocampo
force-pushed
the
add_perror_from_musl
branch
5 times, most recently
from
2cc3f9a to
cd549ad
Compare
johnedocampo
changed the title
Add the perror symbol from musl to our Chrobalt build. b/420683722
johnedocampo
force-pushed
the
add_perror_from_musl
branch
from
29fc506 to
65417fd
Compare
johnedocampo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the perror symbol from musl to our Chrobalt build.
Currently, we do not support the existing implementation of
perror.After some discussion offline, we decided that it would be best to still introduce the symbol into Chrobalt with aCOBALT_HERMETIC_HACKwhich provides a temporary implementation that we currently support.Once the implementation for the iobuffer has been introduced, we can update perror's implementation to a more proper solution.
Bug: 420683722