Cherry pick PR #8833: cobalt: Refactor histogram fetching process for unit tests#9080
Draft
cobalt-github-releaser-bot wants to merge 1 commit into26.eapfrom
Draft
Cherry pick PR #8833: cobalt: Refactor histogram fetching process for unit tests#9080cobalt-github-releaser-bot wants to merge 1 commit into26.eapfrom
cobalt-github-releaser-bot wants to merge 1 commit into26.eapfrom
Conversation
Move histogram fetching and delta calculation logic from H5vccMetricsImpl to a new HistogramFetcher class. This refactoring ensures that histogram data snapshot logic can be tested by unit tests. Bug: 467384307 (cherry picked from commit 2236909)
Collaborator
Author
|
Caution There were merge conflicts while cherry picking! Check out cherry-pick-26.eap-8833 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/21965456058 for details. |
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #8833
Move histogram fetching and delta calculation logic from H5vccMetricsImpl to a new HistogramFetcher class. This refactoring ensures that histogram data snapshot logic can be tested by unit tests.
Bug: 467384307