tvOS: Set firmware version in User Agent string#9091
Open
rakuco wants to merge 1 commit intoyoutube:mainfrom
Open
tvOS: Set firmware version in User Agent string#9091rakuco wants to merge 1 commit intoyoutube:mainfrom
rakuco wants to merge 1 commit intoyoutube:mainfrom
Conversation
Pass the OS version as firmware version just like C25 did, otherwise this field would be set to "Unknown". Bug: 442760345
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Collaborator
Author
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly sets the firmware version in the User Agent string for tvOS by using the operating system version. The change is simple, confined to the tvOS platform-specific initialization, and directly addresses the goal of preventing the firmware version from being reported as 'Unknown'. The implementation is straightforward and looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the OS version as firmware version just like C25 did, otherwise this field would be set to "Unknown".
Bug: 442760345