Skip to content

tvOS: Set firmware version in User Agent string#9091

Open
rakuco wants to merge 1 commit intoyoutube:mainfrom
rakuco:tvos/ua-string-firmware-fix
Open

tvOS: Set firmware version in User Agent string#9091
rakuco wants to merge 1 commit intoyoutube:mainfrom
rakuco:tvos/ua-string-firmware-fix

Conversation

@rakuco
Copy link
Collaborator

@rakuco rakuco commented Feb 13, 2026

Pass the OS version as firmware version just like C25 did, otherwise this field would be set to "Unknown".

Bug: 442760345

Pass the OS version as firmware version just like C25 did, otherwise this
field would be set to "Unknown".

Bug: 442760345
@rakuco rakuco requested a review from a team as a code owner February 13, 2026 14:02
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


tvos: Set firmware version in User Agent string

Set the firmware version for tvOS in the User Agent string.
Previously, this field was set to "Unknown". This change populates
it with the actual OS version, aligning with C25 behavior.

Bug: 442760345

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@rakuco
Copy link
Collaborator Author

rakuco commented Feb 13, 2026

cc @abhijeetk @jkim-julie @Gyuyoung

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly sets the firmware version in the User Agent string for tvOS by using the operating system version. The change is simple, confined to the tvOS platform-specific initialization, and directly addresses the goal of preventing the firmware version from being reported as 'Unknown'. The implementation is straightforward and looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant