cleanup: Remove unused Java_MediaCodecBridge_start#9101
Open
borongc wants to merge 1 commit intoyoutube:mainfrom
Open
cleanup: Remove unused Java_MediaCodecBridge_start#9101borongc wants to merge 1 commit intoyoutube:mainfrom
borongc wants to merge 1 commit intoyoutube:mainfrom
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a good cleanup, removing an unused @CalledByNative annotation, which will stop the generation of an unnecessary JNI function. I've added one suggestion for a potential further cleanup: if the start() method is now completely unused, it could be removed entirely.
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java
Show resolved
Hide resolved
ac467e6 to
40c7458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the MediaCodecBridge.start() method, previously callable
from native code. This method is no longer invoked from the native
Cobalt codebase and is thus unused. Removing it reduces code
footprint and potential for future confusion or errors.
Issue: 484411174