Skip to content

cleanup: Remove unused Java_MediaCodecBridge_start#9101

Open
borongc wants to merge 1 commit intoyoutube:mainfrom
borongc:unused_MediaCodecBridge_start
Open

cleanup: Remove unused Java_MediaCodecBridge_start#9101
borongc wants to merge 1 commit intoyoutube:mainfrom
borongc:unused_MediaCodecBridge_start

Conversation

@borongc
Copy link
Contributor

@borongc borongc commented Feb 13, 2026

Remove the MediaCodecBridge.start() method, previously callable
from native code. This method is no longer invoked from the native
Cobalt codebase and is thus unused. Removing it reduces code
footprint and potential for future confusion or errors.

gen/jni_headers/cobalt/android/jni_headers/MediaCodecBridge_jni.h:407:17: warning: unused function 'Java_MediaCodecBridge_start' [-Wunused-function]
  407 | static jboolean Java_MediaCodecBridge_start(JNIEnv* env, const jni_zero::JavaRef<jobject>& obj) {
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Issue: 484411174

@borongc borongc requested a review from a team as a code owner February 13, 2026 23:22
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


android: Remove unused MediaCodecBridge.start()

Remove the MediaCodecBridge.start() method, previously callable
from native code. This method is no longer invoked from the native
Cobalt codebase and is thus unused. Removing it reduces code
footprint and potential for future confusion or errors.

Bug: 484411174

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good cleanup, removing an unused @CalledByNative annotation, which will stop the generation of an unnecessary JNI function. I've added one suggestion for a potential further cleanup: if the start() method is now completely unused, it could be removed entirely.

@borongc borongc force-pushed the unused_MediaCodecBridge_start branch from ac467e6 to 40c7458 Compare February 13, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant