feat(imagePreview): Added image preview ability to rotate images#13205
Open
lzxiaoqi wants to merge 10 commits intoyouzan:mainfrom
Open
feat(imagePreview): Added image preview ability to rotate images#13205lzxiaoqi wants to merge 10 commits intoyouzan:mainfrom
lzxiaoqi wants to merge 10 commits intoyouzan:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13205 +/- ##
==========================================
- Coverage 89.64% 89.50% -0.14%
==========================================
Files 257 257
Lines 7008 7071 +63
Branches 1733 1745 +12
==========================================
+ Hits 6282 6329 +47
- Misses 382 396 +14
- Partials 344 346 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
感谢你的 PR!这个功能的实现可能比表面看起来更复杂,需要注意以下几点:
|
Contributor
Author
|
@inottn 您好 按照优化建议调整了下。看是否可行 |
Collaborator
|
抱歉回复晚了。我查看了许多相关的应用后,觉得我们可以将旋转行为限定为 90 度,不支持其他角度。暂时没有想到用户需要非 90 度旋转的场景,这样的设计也能让代码更简洁。 |
Contributor
Author
|
@inottn 有道理 已经调整 |
Collaborator
|
测试了下,当旋转后双击放大,拖动时的边界似乎有问题。 |
Contributor
Author
|
确实是有这个问题,这次修改 maxMoveX 和 maxMoveY 的计算逻辑,考虑旋转后的尺寸和缩放比例,我试了下应该是正常的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before submitting a pull request, please read the contributing guide.
在提交 pull request 之前,请阅读 贡献指南。
#13153

上面issue中提到的ImagePreview组件增加图片的旋转功能