fix(Popup): add PopupEmitsProps to Popup#13755
Open
zybieku wants to merge 1 commit intoyouzan:mainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13755 +/- ##
==========================================
+ Coverage 89.60% 89.97% +0.36%
==========================================
Files 257 257
Lines 7013 7050 +37
Branches 1736 1747 +11
==========================================
+ Hits 6284 6343 +59
+ Misses 384 370 -14
+ Partials 345 337 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please read the contributing guide.
在提交 pull request 之前,请阅读 贡献指南。
issues(#13754)
1 Popup保留Emits的事件类型 PopupEmitsProps
2 actionSheet ,Dialog继承PopupEmitsProps ,不修改现有代码逻辑,只改动类型