feat(SwipeCell): add customizable threshold prop for swipe actions#13792
feat(SwipeCell): add customizable threshold prop for swipe actions#13792quietdw wants to merge 3 commits intoyouzan:mainfrom
Conversation
Made-with: Cursor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此 PR 为 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13792 +/- ##
==========================================
+ Coverage 89.60% 89.99% +0.38%
==========================================
Files 257 257
Lines 7013 7063 +50
Branches 1736 1755 +19
==========================================
+ Hits 6284 6356 +72
+ Misses 384 371 -13
+ Partials 345 336 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
我这次 PR 只改动了 SwipeCell(新增 threshold props、补测试与文档),本地跑 SwipeCell 相关用例均通过。 当前 CI 失败的报错指向 src/composables/use-height.ts(setTimeout 在测试环境 teardown 后仍触发,最终在 Node 环境里访问 window 导致 ReferenceError: window is not defined),触发点出现在 src/submit-bar/test/index.spec.ts 执行期间。看起来与本 PR 修改无关,更像是测试环境/异步定时器清理相关的已有问题。 我可以按维护建议另开 PR 专门修复 use-height.ts 的定时器清理/SSR 兼容,避免本 PR 引入非单一性改动; |
SwipeCell的threshold 支持自定义。
用户反馈threshold太小了,容易误触。