Allow other (non-sub)classes to handle binary ufuncs with unyt_array#641
Open
kyleaoman wants to merge 3 commits into
Open
Allow other (non-sub)classes to handle binary ufuncs with unyt_array#641kyleaoman wants to merge 3 commits into
unyt_array#641kyleaoman wants to merge 3 commits into
Conversation
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#572 added the ability for subclasses of
unyt_arrayto intervene before and after numpy ufunc calls to "prepare" the arguments and "finalize" the result.In this PR I propose to extend this ability to classes that are not subclasses, allowing them to implement
__unyt_ufunc_prepare__and__unyt_ufunc_finalize__if they wish. Note that the other class cannot control the result via e.g.__mul__and__rmul__because control ends up inunyt_array.__array_ufunc__and leads to an exception leaving the other class no chance to intervene.The included tests have a bare-bones example of how a class might use this functionality.
#640 is related.