Skip to content

[BUG] minor typing.ClassVar fix for class variables of Index #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mabruzzo wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −9
Open

[BUG] minor typing.ClassVar fix for class variables of Index #5189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae9da09
ClassVar typefix
mabruzzo Jun 26, 2025
ce65328
remove the unused class variable
mabruzzo Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yt/geometry/geometry_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import abc
import os
import weakref
from typing import ClassVar

import numpy as np

Expand All @@ -21,8 +22,7 @@
class Index(ParallelAnalysisInterface, abc.ABC):
"""The base index class"""

_unsupported_objects: tuple[str, ...] = ()
_index_properties: tuple[str, ...] = ()
_unsupported_objects: ClassVar[tuple[str, ...]] = ()

def __init__(self, ds, dataset_type):
ParallelAnalysisInterface.__init__(self)
Expand Down
7 changes: 0 additions & 7 deletions yt/geometry/grid_geometry_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,6 @@ class GridIndex(Index, abc.ABC):

float_type = "float64"
_preload_implemented = False
_index_properties = (
"grid_left_edge",
"grid_right_edge",
"grid_levels",
"grid_particle_count",
"grid_dimensions",
)

def _setup_geometry(self):
mylog.debug("Counting grids.")
Expand Down
Loading