AMR: Expand particle deposition onto the grid to vector fields.#5227
AMR: Expand particle deposition onto the grid to vector fields.#5227AnatoleStorck wants to merge 14 commits into
Conversation
|
Just to add, I am currently only considering |
chrishavlin
added
enhancement
|
@cphyc some octree enhancements/changes here that you might be interested in checking out when you're back from holiday :) |
|
@AnatoleStorck would be happy to look more at this after the test failures are addressed. |
|
I'd love to see this functionality in yt. Let me know if there are ways I can assist in testing this or debugging. |
|
Note for @AnatoleStorck and @cphyc, the |
cphyc
force-pushed
the
add_vector_field_support_to_deposit
branch
from
34fba04 to
3526408
Compare
|
@chummels this should support SPH datasets, but I have never used an SPH dataset, and I'm not sure what the particle deposition would mean for SPH? Onto what are you deposing? Given my ignorance, I haven't really tested this, but it'd be amazing if you could give it a go |
|
We still have failures for AMR (non-octree) datasets. It seems that vector fields end up being stored vector-first, i.e., with shape |
This works, but is still using the 'particle_deposit_vector.pyx' code. The latter is a duplication from 'particle_deposit.pyx', which only works for scalar fields but could be replaced with the more generic vector version.
Assume that we're depositing vector, and treat scalar fields as a special case of vectors
cphyc
force-pushed
the
add_vector_field_support_to_deposit
branch
from
9ecd82c to
f631aa6
Compare
5 participants
PR Summary
Currently, only scalar quantites of particles can be deposited to the grid (such as mass), with final shape (Ncells,) I want to be able to deposit a vector quantity (stellar spectra of each star particle) onto the grid with shape (Ncells, spectra_length), with the main goal to build spectra for each cell (nebular continuum + emission lines, and stellar spectra.) I have not been able to make the deposition of the vector fields work yet, so any help is greatly appreciated.
PR Checklist