Skip to content

CLN: remove unneeded system-level package installs from ci_install.sh #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CLN: remove unneeded system-level package installs from ci_install.sh #5332

wants to merge 1 commit into from

Conversation

@neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Nov 22, 2025

PR Summary

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@neutrinoceros neutrinoceros added infrastructure Related to CI, versioning, websites, organizational issues, etc dead code removing internal bits that have no effect labels Nov 22, 2025
@neutrinoceros neutrinoceros marked this pull request as ready for review November 23, 2025 08:40
@neutrinoceros neutrinoceros marked this pull request as draft November 23, 2025 16:22
@neutrinoceros neutrinoceros force-pushed the cln/cleanup-unused-workaround branch from 155e51a to a935568 Compare November 23, 2025 16:48
@neutrinoceros neutrinoceros changed the title CLN: remove unused workaround in ci_install.sh CLN: remove unneeded system-level package installs from ci_install.sh Nov 23, 2025
@neutrinoceros neutrinoceros added this to the 4.5.0 milestone Nov 23, 2025
@neutrinoceros neutrinoceros marked this pull request as ready for review November 23, 2025 17:01
@neutrinoceros neutrinoceros marked this pull request as draft November 23, 2025 17:04
@neutrinoceros neutrinoceros force-pushed the cln/cleanup-unused-workaround branch 2 times, most recently from 0dbe7f1 to 37eadf8 Compare November 23, 2025 18:25
@neutrinoceros neutrinoceros force-pushed the cln/cleanup-unused-workaround branch from 37eadf8 to d2f001d Compare November 23, 2025 18:29
@neutrinoceros neutrinoceros marked this pull request as ready for review November 24, 2025 06:22
chrishavlin
chrishavlin approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

Assignees

No one assigned

Labels

dead code removing internal bits that have no effect infrastructure Related to CI, versioning, websites, organizational issues, etc

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@neutrinoceros @chrishavlin