Reserve npt for numpy.typing#5349
Open
chrishavlin wants to merge 1 commit into
Open
Conversation
Member
|
This seems right -- should we hold on this? |
cphyc
approved these changes
May 1, 2026
Member
cphyc
left a comment
cphyc
left a comment
There was a problem hiding this comment.
LGTM, but I think you're missing one hit in yt/testing.py, line 1882. It's within a test itself, so shouldn't cause any collision tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We've got a couple spots where we
import numpy.testing as npt, but it's become pretty ubiquitous toimport numpy.typing as npt. with #5346, we'll have a bunch more uses ofnumpy.typing as nptacross the codebase , so this PR cleans up just a few spots to avoid future alias collisions (5346 will change the one remaining stop inyt/testing.pynot touched by this PR).PR Checklist